Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(crypto-helper): jwt: implement RS384 signature algorithm #9

Merged
merged 5 commits into from
Apr 5, 2023
Merged

feat(crypto-helper): jwt: implement RS384 signature algorithm #9

merged 5 commits into from
Apr 5, 2023

Conversation

rwwwx
Copy link
Contributor

@rwwwx rwwwx commented Apr 4, 2023 •
edited
Loading

#3

@TheBestTvarynka
Copy link
Owner

you have cool branch name)))

TheBestTvarynka
TheBestTvarynka requested changes Apr 4, 2023
View reviewed changes
Copy link
Owner

@TheBestTvarynka TheBestTvarynka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two small comments. Fix them and I'll approve this PR

src/jwt/signature.rs Outdated Show resolved Hide resolved
src/jwt/signature.rs Outdated Show resolved Hide resolved
@rwwwx rwwwx requested a review from TheBestTvarynka April 5, 2023 14:34
@TheBestTvarynka TheBestTvarynka merged commit 3019033 into TheBestTvarynka:main Apr 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@TheBestTvarynka TheBestTvarynka TheBestTvarynka approved these changes

Assignees

@rwwwx rwwwx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwwwx @TheBestTvarynka