Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix for empty directories not released yet #49

Open
binaryDiv opened this issue Jan 31, 2025 · 4 comments
Open

Fix for empty directories not released yet #49

binaryDiv opened this issue Jan 31, 2025 · 4 comments

Comments

@binaryDiv
Copy link
Contributor

Hi,

it seems like the fix for the empty directories (#40) is not part of any release yet.

I can see a "Release 2.0.3" commit in the commit history, and if I use the main branch in my actions workflow, the empty directory bug is fixed, but there is no release tag for it yet.

I'll probably just use the commit hash in my workflows for now, but a proper release tag (and updating the "v2" tag) would be great. :)

Thanks!

@TheBrutalX
Copy link
Owner

Hi,
i released your change in version 2.0.2 on january 25, and aligned the latest and v2 tag at the same check-in 21271b6

2.0.3 is a hotfix pipeline fix for the release of the v2 tag

Here is the tag list 2.0.2, V2, latest

And here the comparison from 2.0.1 and 2.0.2

There have been problems with the release of the new pipeline, and the check-in story is a bit more complex than I intended

For any doubt I remain available, greetings🤞

@binaryDiv
Copy link
Contributor Author

Thanks for the quick reply :)

I used the "v2" tag for a test build and the resulting zip file had the empty dir issue. I've verified in the build logs that it did use the correct commit (21271b6). See here: https://github.com/binaryDiv/factorio-its-about-time/actions/runs/13077346720

I've checked the repository, and while the source code does contain the fix, the bundle.js was only updated in the commit that followed the release commit: 6827373

@binaryDiv
Copy link
Contributor Author

Hi,
is there any news on this? :)

@TheBrutalX
Copy link
Owner

Hi, I will look into it in the next few days

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants