Account for flaky invocationDetails presence in Cypress tests #6517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This quickfix PR will ensure that the fail fast logic of the cypress tests does not result in further crashes.
Changes
invocationDetails
not being in the context which can sometimes be the caseTesting
Notes for Reviewers
It appears as though the
invocationDetails
can sometimes be missing from the context. More info on that here:cypress-io/cypress#3090 (comment)
So I believe it's best to add a check for it and just run the remaining tests anyway if necessary. It should be noted that this bit of the fail-fast logic only fires when the connected test already failed organically. So typically the logic should not result in a test failure in itself, but it can obfuscate the actual failure of the underlying test.
cc @adriansmares
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.