Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Account for flaky invocationDetails presence in Cypress tests #6517

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

kschiffer
Copy link
Contributor

Summary

This quickfix PR will ensure that the fail fast logic of the cypress tests does not result in further crashes.

Changes

  • Account for invocationDetails not being in the context which can sometimes be the case

Testing

  • Manual testing, this is a pure dev tooling change

Notes for Reviewers

It appears as though the invocationDetails can sometimes be missing from the context. More info on that here:
cypress-io/cypress#3090 (comment)

So I believe it's best to add a check for it and just run the remaining tests anyway if necessary. It should be noted that this bit of the fail-fast logic only fires when the connected test already failed organically. So typically the logic should not result in a test failure in itself, but it can obfuscate the actual failure of the underlying test.

cc @adriansmares

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added bug Something isn't working tooling Development tooling labels Sep 5, 2023
@kschiffer kschiffer added this to the Sep 2023 milestone Sep 5, 2023
@kschiffer kschiffer requested a review from ryaplots as a code owner September 5, 2023 05:24
@kschiffer kschiffer self-assigned this Sep 5, 2023
@github-actions github-actions bot removed the tooling Development tooling label Sep 5, 2023
@kschiffer kschiffer merged commit 85bc88d into v3.27 Sep 8, 2023
@kschiffer kschiffer deleted the fix/cypress-fail-fast-flaky branch September 8, 2023 05:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants