Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test on CPU #68

Merged
merged 18 commits into from
Mar 25, 2022
Merged

Test on CPU #68

merged 18 commits into from
Mar 25, 2022

Conversation

simsurace
Copy link
Member

@simsurace simsurace commented Mar 16, 2022

This adds fallbacks that run on the CPU for all functions and tests those also, such that the code can be tested even on machines without CPU (like the GitHub CI runners).

In some cases this was achieved through generic programming, but not in all. There is some code duplication that we can clean up at a later stage.

Closes #64.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #68 (cbc192c) into master (8efba2e) will increase coverage by 34.95%.
The diff coverage is 75.67%.

@@             Coverage Diff             @@
##           master      #68       +/-   ##
===========================================
+ Coverage   32.95%   67.90%   +34.95%     
===========================================
  Files          14       14               
  Lines         610      701       +91     
===========================================
+ Hits          201      476      +275     
+ Misses        409      225      -184     
Impacted Files Coverage Δ
src/simulate.jl 86.44% <ø> (+86.44%) ⬆️
src/models.jl 62.03% <48.97%> (+15.60%) ⬆️
src/propagate.jl 82.35% <62.50%> (+12.78%) ⬆️
src/myopic.jl 90.76% <82.60%> (+17.42%) ⬆️
src/resample.jl 55.62% <93.61%> (+55.62%) ⬆️
src/jitter.jl 47.16% <93.75%> (+47.16%) ⬆️
src/filter.jl 100.00% <100.00%> (+87.50%) ⬆️
src/likelihood.jl 93.75% <100.00%> (+93.75%) ⬆️
src/visualize.jl 0.00% <0.00%> (ø)
... and 10 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@simsurace simsurace marked this pull request as ready for review March 24, 2022 12:58
@camillegontier camillegontier merged commit a957ab9 into master Mar 25, 2022
@simsurace simsurace deleted the test_cpu branch March 25, 2022 14:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve code coverage
2 participants