Skip to content
This repository has been archived by the owner on Sep 1, 2024. It is now read-only.

Commit

Permalink
Improve config and update dependencies (#6)
Browse files Browse the repository at this point in the history
  • Loading branch information
ThomasVitale authored Jun 25, 2023
1 parent 2a91102 commit 3d5a6bb
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 27 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ jobs:
registry-server: ghcr.io
registry-username: ${{ github.actor }}
image: ${{ github.repository }}
version: 0.2.0
version: 0.2.1
secrets:
pull-request-token: ${{ secrets.GH_ORG_PAT }}
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

![Test Workflow](https://github.com/kadras-io/cert-manager-issuers/actions/workflows/test.yml/badge.svg)
![Release Workflow](https://github.com/kadras-io/cert-manager-issuers/actions/workflows/release.yml/badge.svg)
[![The SLSA Level 3 badge](https://slsa.dev/images/gh-badge-level3.svg)](https://slsa.dev/spec/v0.1/levels)
[![The SLSA Level 3 badge](https://slsa.dev/images/gh-badge-level3.svg)](https://slsa.dev/spec/v1.0/levels)
[![The Apache 2.0 license badge](https://img.shields.io/badge/License-Apache_2.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)
[![Follow us on Twitter](https://img.shields.io/static/v1?label=Twitter&message=Follow&color=1DA1F2)](https://twitter.com/kadrasIO)

Expand Down Expand Up @@ -104,7 +104,7 @@ The cert-manager-issuers package has the following configurable properties.
| `namespace` | `cert-manager` | The namespace where cert-manager is deployed. |
| `letsencrypt.include` | `false` | Whether to include a ClusterIssuer for Let's Encrypt. |
| `letsencrypt.staging` | `true` | Whether to use Let's Encrypt staging, recommended for non-production environments. |
| `letsencrypt.email` | `""` | The email address that Let's Encrypt will use to send info on expiring certificates or issues. |
| `letsencrypt.email` | `""` | The email address that Let's Encrypt will use to send info on expiring certificates or other issues. |

</details>

Expand Down
4 changes: 2 additions & 2 deletions package/config/kapp-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ kind: Config

minimumRequiredVersion: 0.50.0

#! Wait rules specify how to wait for resources that kapp does not wait for by default.
#! See more about the wait rules: https://carvel.dev/kapp/docs/latest/config/#waitrules.
# Wait rules specify how to wait for resources that kapp does not wait for by default.
# See more about the wait rules: https://carvel.dev/kapp/docs/latest/config/#waitrules.
waitRules:

- supportsObservedGeneration: false
Expand Down
2 changes: 1 addition & 1 deletion package/config/values-schema.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ letsencrypt:
include: false
#@schema/desc "Whether to use Let's Encrypt staging, recommended for non-production environments."
staging: true
#@schema/desc "The email address that Let's Encrypt will use to send info on expiring certificates or issues."
#@schema/desc "The email address that Let's Encrypt will use to send info on expiring certificates or other issues."
#@schema/validation min_len=5, when=lambda _, ctx: ctx.parent["include"]
email: ""
4 changes: 2 additions & 2 deletions test/integration/kuttl-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ commands:
- script: |
kubectl config set-context --current --namespace=tests && \
kapp deploy -a cert-manager-package -y \
-f https://github.com/kadras-io/package-for-cert-manager/releases/download/v1.12.1/package.yml \
-f https://github.com/kadras-io/package-for-cert-manager/releases/download/v1.12.1/metadata.yml
-f https://github.com/kadras-io/package-for-cert-manager/releases/download/v1.12.2/package.yml \
-f https://github.com/kadras-io/package-for-cert-manager/releases/download/v1.12.2/metadata.yml
- script: |
kubectl config set-context --current --namespace=tests && \
kapp deploy -a dependencies -y -f ./test/setup/dependencies
2 changes: 1 addition & 1 deletion test/setup/dependencies/cert-manager.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ spec:
packageRef:
refName: cert-manager.packages.kadras.io
versionSelection:
constraints: 1.12.1
constraints: 1.12.2
8 changes: 2 additions & 6 deletions test/setup/kind/v1.25/kind-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
image: kindest/node:v1.25.9
image: kindest/node:v1.25.11
- role: worker
image: kindest/node:v1.25.9
- role: worker
image: kindest/node:v1.25.9
- role: worker
image: kindest/node:v1.25.9
image: kindest/node:v1.25.11
8 changes: 2 additions & 6 deletions test/setup/kind/v1.26/kind-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
image: kindest/node:v1.26.4
image: kindest/node:v1.26.6
- role: worker
image: kindest/node:v1.26.4
- role: worker
image: kindest/node:v1.26.4
- role: worker
image: kindest/node:v1.26.4
image: kindest/node:v1.26.6
8 changes: 2 additions & 6 deletions test/setup/kind/v1.27/kind-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
image: kindest/node:v1.27.2
image: kindest/node:v1.27.3
- role: worker
image: kindest/node:v1.27.2
- role: worker
image: kindest/node:v1.27.2
- role: worker
image: kindest/node:v1.27.2
image: kindest/node:v1.27.3

0 comments on commit 3d5a6bb

Please # to comment.