NATS: add default ack wait timeout (#26)

* NATS: add default ack wait timeout The lack of default value causes ACK timeout immediately, if not supplied.
ThreeDotsLabs · Dec 20, 2018 · b161620 · b161620
1 parent c99b3f5
commit b161620
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/message/infrastructure/nats/subscriber.go b/message/infrastructure/nats/subscriber.go
@@ -83,15 +83,16 @@ func (c *StreamingSubscriberConfig) setDefaults() {
 	if c.CloseTimeout <= 0 {
 		c.CloseTimeout = time.Second * 30
 	}
+	if c.AckWaitTimeout <= 0 {
+		c.AckWaitTimeout = time.Second * 30
+	}
 
 	c.StanSubscriptionOptions = append(
 		c.StanSubscriptionOptions,
 		stan.SetManualAckMode(), // manual AckMode is required to support acking/nacking by client
+		stan.AckWait(c.AckWaitTimeout),
 	)
 
-	if c.AckWaitTimeout != 0 {
-		c.StanSubscriptionOptions = append(c.StanSubscriptionOptions, stan.AckWait(c.AckWaitTimeout))
-	}
 	if c.DurableName != "" {
 		c.StanSubscriptionOptions = append(c.StanSubscriptionOptions, stan.DurableName(c.DurableName))
 	}