This repository was archived by the owner on Dec 10, 2018. It is now read-only.
Fixes parsing of const defs with separators #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Thrift IDL grammar specifies that constant definitions may be terminated with a separator, which was not included in the thriftpy parser.
|
👍 Thank you! |
hit9
added a commit
that referenced
this pull request
May 29, 2015
Fixes parsing of const defs with separators
|
Any chance you could cut a release soon? |
|
@laserson v0.3.1 released ;) |
|
Thanks, @lxyu! |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Thrift IDL grammar specifies that constant definitions may be terminated with a separator, which was not included in the thriftpy parser.