-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #77 from adknudson/main
add missing `transforms` variable in `geom_vline`
- Loading branch information
Showing
2 changed files
with
123 additions
and
79 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,41 +1,41 @@ | ||
function geom_hline(args...; kwargs...) | ||
aes_dict, args_dict, transforms = extract_aes(args, kwargs) | ||
|
||
args_dict["geom_name"] = "geom_hline" | ||
|
||
if haskey(args_dict, "yintercept") | ||
args_dict["data"] = DataFrame(Numeric = args_dict["yintercept"]) | ||
aes_dict["yintercept"] = :Numeric | ||
end | ||
|
||
return build_geom(aes_dict, args_dict, | ||
return build_geom(aes_dict, args_dict, | ||
["yintercept"], # required aesthetics | ||
:HLines, | ||
do_nothing, | ||
transforms) # function for visual layer | ||
do_nothing, | ||
transforms) # function for visual layer | ||
end | ||
|
||
function geom_vline(args...; kwargs...) | ||
aes_dict, args_dict = extract_aes(args, kwargs) | ||
aes_dict, args_dict, transforms = extract_aes(args, kwargs) | ||
|
||
args_dict["geom_name"] = "geom_vline" | ||
|
||
if haskey(args_dict, "xintercept") | ||
args_dict["data"] = DataFrame(Numeric = args_dict["xintercept"]) | ||
aes_dict["xintercept"] = :Numeric | ||
end | ||
|
||
return build_geom(aes_dict, args_dict, | ||
return build_geom(aes_dict, args_dict, | ||
["xintercept"], # required aesthetics | ||
:VLines, | ||
do_nothing, | ||
transforms) # function for visual layer | ||
do_nothing, | ||
transforms) # function for visual layer | ||
end | ||
|
||
function geom_hline(plot::GGPlot, args...; kwargs...) | ||
return plot + geom_hline(args...; kwargs...) | ||
return plot + geom_hline(args...; kwargs...) | ||
end | ||
|
||
function geom_vline(plot::GGPlot, args...; kwargs...) | ||
return plot + geom_vline(args...; kwargs...) | ||
end | ||
return plot + geom_vline(args...; kwargs...) | ||
end |
Oops, something went wrong.
0c17afe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuliaRegistrator register
0c17afe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Registration pull request created: JuliaRegistries/General/104880
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via: