Skip to content

Commit

Permalink
Warn users using dense arrays with sparse fragments. (#5116)
Browse files Browse the repository at this point in the history
Support for reading sparse fragments in dense arrays will be removed in
TileDB version 2.27 to be released in September 2024. To make sure these
arrays continue to work after an upgrade to version 2.27 or later,
please consolidate the sparse fragments using a TileDB version 2.26 or
earlier.

For now, this adds a warning to user using dense arrays with sparse
fragment. Support for writing sparse fragments in dense arrays was
removed in TileDB 2.5 and as the user can easily consolidate to get rid
of sparse fragments, the decision was made to remove support for reading
these arrays.

[sc-47348]

---
TYPE: DEPRECATION
DESC: Warn users using dense arrays with sparse fragments.

(cherry picked from commit 7b88c3e)
  • Loading branch information
KiterLuc authored and github-actions[bot] committed Jul 9, 2024
1 parent 902ac23 commit 3d4aa74
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions tiledb/sm/query/query.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1880,6 +1880,18 @@ Status Query::create_strategy(bool skip_checks_serialization) {
all_dense &= frag_md->dense();
}

// We are going to deprecate dense arrays with sparse fragments in 2.27 but
// log a warning for now.
if (array_schema_->dense() && !all_dense) {
LOG_WARN(
"This dense array contains sparse fragments. Support for reading "
"sparse fragments in dense arrays will be removed in TileDB version "
"2.27 to be released in September 2024. To make sure this array "
"continues to work after an upgrade to version 2.27 or later, please "
"consolidate the sparse fragments using a TileDB version 2.26 or "
"earlier.");
}

if (is_dimension_label_ordered_read_) {
strategy_ = tdb_unique_ptr<IQueryStrategy>(tdb_new(
OrderedDimLabelReader,
Expand Down

0 comments on commit 3d4aa74

Please # to comment.