Remove UnitTestConfig::array_encryption_key_length #4482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #36397: Remove UnitTestConfig::array_encryption_key_length. |
davisp
force-pushed
the
pd/sc-36397/remove-unit-test-config-enc-key-len
branch
2 times, most recently
from
2608659
to
ee44449
Compare
This field existed to force invalid key lengths. This is unnecessary since we can just set the invalid key lengths in the test. The reason I stopped to remove this is because the test state is improperly persisted between unit tests. If you run `tiledb_unit -d y [capi][encryption]` it will fail because the UnitTestConfig is not reset. It took me so long to debug this issue that I decided to light it on fire and just remove the whole global state and write the tests properly.
davisp
force-pushed
the
pd/sc-36397/remove-unit-test-config-enc-key-len
branch
from
ee44449
to
6c24053
Compare
KiterLuc
approved these changes
Nov 2, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field existed to force invalid key lengths. This is unnecessary since we can just set the invalid key lengths in the test. The reason I stopped to remove this is because the test state is improperly persisted between unit tests. If you run
tiledb_unit -d y [capi][encryption]it will fail because the UnitTestConfig is not reset.It took me so long to debug this issue that I decided to light it on fire and just remove the whole global state and write the tests properly.
TYPE: IMPROVEMENT
DESC: Remove UnitTestConfig::array_encryption_key_length