Add CurrentDomain API support. #5041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiterLuc
reviewed
Jun 5, 2024
| memory_tracker_->get_resource(MemoryType::ENUMERATION)) { | ||
| memory_tracker_->get_resource(MemoryType::ENUMERATION)) | ||
| , shape_to_expand_( | ||
| make_shared<const Shape>(memory_tracker, constants::shape_version)) { |
There was a problem hiding this comment.
Shouldn't this be nullptr?
There was a problem hiding this comment.
nullptr is better, thanks.
robertbindar
force-pushed
the
rbin/ch42489/shape_api
branch
from
7bd7756
to
9df9e76
Compare
KiterLuc
approved these changes
Jun 7, 2024
|
https://app.shortcut.com/tiledb-inc/story/49157/check-and-test-out-of-order-ranges-for-currentdomain Followup for out of order ranges. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the foundation for the CurrentDomain API:
To be done C and CPP API that wrap APIs defined here.
[sc-42489]
TYPE: FEATURE
DESC: Add CurrentDomain API support.