Add CMake option to disable auto-downloading of vcpkg. #5048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-48929
This PR adds a CMake option to disable auto-downloading of vcpkg, as requested in msys2/MINGW-packages#21081 (comment). There is already an environment variable that serves the same purpose, but the CMake option has the advantage of being cached across configures.
I also updated the error message when
TILEDB_VCPKGis disabled, making the migration path more clear.Validated by configuring locally with this option specified, and observing that vcpkg was not downloaded, and
find_packagecalls failed.TYPE: BUILD
DESC: Automatic downloading of vcpkg can be disabled by enabling the
TILEDB_DISABLE_AUTO_VCPKGCMake option, in addition to setting the environment variable with trhe same name.