Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Sort individual chunks in chunk_view #5052

Merged
merged 42 commits into from
Jun 13, 2024
Merged

Sort individual chunks in chunk_view #5052

merged 42 commits into from
Jun 13, 2024

Conversation

lums658
Copy link
Contributor

@lums658 lums658 commented Jun 6, 2024 •
edited by KiterLuc
Loading

This PR comprises the test file unit_sort_chunk that tests that individual chunks of a chunk_view can be separately sorted. It tests a std::vector and a zip_view of std::vector and alt_var_length_view.

[sc-49444]

TYPE: IMPROVEMENT
DESC: Tests that the chunks in a chunk_view can be separately sorted.

lums658 and others added 30 commits May 31, 2024 11:27
@lums658
Reorganize utility classes
5797ac2
@lums658
clang-format [skip ci]
0a8456e
@lums658
Initial chunk_view implementation and first unit tests
b6d3097
@lums658
Passing concept related unit tests [skip ci]
26a12da
@lums658
More unit tests [skip ci]
46a6ad7
@lums658
Iterators / values [skip ci]
ae165a6
@lums658
clang-format
0b9c5a3
@lums658
Merge branch 'dev' into lums/sc-48621/block-view
b259a76
@lums658
Add unit test for larger vector and for assigning to chunk elements […
0cfa71f 
…skip ci]
@lums658
chunk_view of a chunk_view unit test [skip ci]
1b440e6
@lums658
chunk_view of a permutation view unit test [skip ci]
9f15d08
@lums658
chunk_view of a permutation view unit test [skip ci]
3f1c635
@lums658
chunk_view of a permutation view unit test [skip ci]
e14d657
@lums658
chunk_view of a permutation view unit test [skip ci]
8939b2b
@lums658
Merge branch 'dev' into lums/sc-48753/view-combos
0107665
@lums658 @KiterLuc
Reorganize utility classes
105a77e
@lums658 @KiterLuc
Separate unit tests to individual tests
1fd57b7
@KiterLuc
Tweaks to the cmake files.
b1826f1
@lums658 @KiterLuc
clang-format [skip ci]
cd5ea4d
@lums658 @KiterLuc
Initial chunk_view implementation and first unit tests
9054633
@lums658 @KiterLuc
Passing concept related unit tests [skip ci]
7969154
@lums658 @KiterLuc
More unit tests [skip ci]
c6af3e6
@lums658 @KiterLuc
Iterators / values [skip ci]
30496e8
@lums658 @KiterLuc
clang-format
0ae3311
@lums658
Complete merge [skip ci]
19cc63a
@lums658
Address organizational and namespace comments [skip ci]
dba2a43
@lums658
Address PR comments, clang-format
79f1471
@lums658
chunk of zip and zip of chunk
6a7763b
@lums658
__div_ceil -> detail::div_ceil
f98af2b
@lums658
Fix directory names
560882d
@lums658 lums658 requested a review from KiterLuc June 6, 2024 00:15
KiterLuc
KiterLuc approved these changes Jun 13, 2024
View reviewed changes
tiledb/common/util/test/unit_permutation_sort.cc Outdated Show resolved Hide resolved
tiledb/common/util/test/unit_permutation_sort.cc Outdated Show resolved Hide resolved
tiledb/common/util/test/unit_permutation_sort.cc Outdated Show resolved Hide resolved
tiledb/common/util/test/unit_permutation_sort.cc Outdated Show resolved Hide resolved
tiledb/common/util/test/unit_permutation_sort.cc Outdated Show resolved Hide resolved
tiledb/common/util/test/unit_sort_chunk.cc Outdated Show resolved Hide resolved
tiledb/common/util/test/unit_sort_chunk.cc Outdated Show resolved Hide resolved
tiledb/common/util/test/unit_sort_chunk.cc Outdated Show resolved Hide resolved
tiledb/common/util/test/unit_sort_chunk.cc Outdated Show resolved Hide resolved
@KiterLuc KiterLuc marked this pull request as ready for review June 13, 2024 14:48
@KiterLuc KiterLuc merged commit 5577973 into dev Jun 13, 2024
62 checks passed
@KiterLuc KiterLuc deleted the lums/tmp/sort-chunks branch June 13, 2024 16:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@KiterLuc KiterLuc KiterLuc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lums658 @KiterLuc