Disable nightly testing of HDFS and log a warning when HDFS is enabled. #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only build but not run tests.
KiterLuc
reviewed
Jun 14, 2024
cmake/Options/BuildOptions.cmake
Outdated
| @@ -53,6 +53,10 @@ if (NOT TILEDB_VCPKG) | |||
| message(FATAL_ERROR "Disabling TILEDB_VCPKG is not supported. To disable automatically downloading vcpkg, enable the TILEDB_DISABLE_AUTO_VCPKG option, or set ENV{TILEDB_DISABLE_AUTO_VCPKG} to any value.") | |||
| endif() | |||
|
|
|||
| if (TILEDB_HDFS) | |||
| message(DEPRECATION "The HDFS storage backend is deprecated and untested. It will be removed in TileDB 2.28.") | |||
There was a problem hiding this comment.
Let's mention that we only test that it builds.
KiterLuc
approved these changes
Jun 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-49481
SC-49482
This PR disables testing HDFS in nightlies. The runs have been very brittle for years when more tests were added in and with the recent addition of many tests to all VFSes, it is now impossible to get a successful run. As we are planning to fully remove support for HDFS in TileDB version 2.28, we have made the decision to not investigate the failures. The Core will still be built with HDFS enabled to catch build-time regressions.
Furthermore, the build script was updated to emit a warning when configuring with
-DTILEDB_HDFS=ON.TYPE: DEPRECATION
DESC: The HDFS backend is no longer officially tested by TileDB. As announced before, it is scheduled to be removed in version 2.28, to be released in Q4 2024.