Fix check for out of bounds dimension in Dimension::dimension_ptr. #5094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone knows why that build is failing? The test I enabled doesn't seem to use deprecated APIs |
robertbindar
force-pushed
the
rbin/ch49597/domain_oob
branch
from
e329e06
to
7fcc6fb
Compare
KiterLuc
reviewed
Jun 17, 2024
| @@ -36,18 +36,27 @@ | |||
| #include "tiledb/sm/enums/datatype.h" | |||
| #include "tiledb/sm/enums/layout.h" | |||
|
|
|||
| #include "tiledb/api/c_api/context/context_api_internal.h" | |||
There was a problem hiding this comment.
This might cause the build issues?
There was a problem hiding this comment.
The issue was that the helpers header includes the CPP header which contains some deprecated declarations.
There was a problem hiding this comment.
We shouldn't add this header to a unit test.
KiterLuc
reviewed
Jun 18, 2024
| #include <test/support/tdb_catch.h> | ||
|
|
||
| using namespace tiledb; | ||
| using namespace tiledb::common; | ||
| using namespace tiledb::sm; | ||
| using namespace tiledb::test; | ||
|
|
||
| struct DomainFx : TemporaryDirectoryFixture {}; |
There was a problem hiding this comment.
Yes, to get a context in a oneliner.
| @@ -36,18 +36,27 @@ | |||
| #include "tiledb/sm/enums/datatype.h" | |||
| #include "tiledb/sm/enums/layout.h" | |||
|
|
|||
| #include "tiledb/api/c_api/context/context_api_internal.h" | |||
There was a problem hiding this comment.
We shouldn't add this header to a unit test.
KiterLuc
reviewed
Jun 18, 2024
| @@ -30,12 +30,16 @@ commence(unit_test array_schema) | |||
| this_target_object_libraries(array_schema) | |||
| # should be `this_target_include_directories`, when available | |||
| target_include_directories(unit_array_schema PUBLIC ${TILEDB_SOURCE_ROOT}/test/support) | |||
| if (NOT MSVC) | |||
| target_compile_options(unit_array_schema PUBLIC -Wno-deprecated-declarations) | |||
| endif() | |||
robertbindar
force-pushed
the
rbin/ch49597/domain_oob
branch
from
8f4dc27
to
bdc735d
Compare
KiterLuc
changed the title
KiterLuc
approved these changes
Jun 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix domain::dimension_ptr(int) out of bounds check.
Also adding a unit test to make sure the issue doesn't regress.
[sc-49597]
TYPE: BUG
DESC: Fix check for out of bounds dimension in Dimension::dimension_ptr.