Fix serialization issue with schema evolution for query v3. #5154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiterLuc
approved these changes
Jul 5, 2024
KiterLuc
changed the title
johnkerl
approved these changes
Jul 5, 2024
| schema = array->array_schemas_all().at(fragment_array_schema_name); | ||
| } else if (array->array_schemas_all().size() > 1) { | ||
| throw ArraySerializationException( | ||
| "Cannot deserialize fragment metadata without an array schema name " |
KiterLuc
pushed a commit
that referenced
this pull request
Jul 5, 2024
Query v3 requires fragment metadata serialization/deserialization inside the array object. However fragment metadata capnp model wasn't including the name of the array schema that each fragment was written with , and in case of schema evolution this was leading to serializing the wrong schema (always the latest) and making the REST server read the wrong data from disk. This PR adds the missing array schema name field and adapts the ser/deser to pick the schema based on that name. [sc-48707] --- TYPE: BUG DESC: Fix serialization issue with schema evolution for query v3.
KiterLuc
added a commit
that referenced
this pull request
Jul 5, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query v3 requires fragment metadata serialization/deserialization inside the array object. However fragment metadata capnp model wasn't including the name of the array schema that each fragment was written with , and in case of schema evolution this was leading to serializing the wrong schema (always the latest) and making the REST server read the wrong data from disk.
This PR adds the missing array schema name field and adapts the ser/deser to pick the schema based on that name.
[sc-48707]
TYPE: BUG
DESC: Fix serialization issue with schema evolution for query v3.