Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to OpenSSL 3. #5174

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Update to OpenSSL 3. #5174

merged 2 commits into from
Jul 13, 2024

Conversation

teo-tsirpanis
Copy link
Member

SC-36844

This PR removes the openssl vcpkg port overlay, which unpins OpenSSL from version 1.1.1.t to whichever is set in the vcpkg builtin-baseline (currently version 3.1.4).

Validated by successfully building the Core on WSL. No warnings or errors about deprecated APIs were emitted by the compiler, which means that this PR does not have to touch any first-party code.


TYPE: IMPROVEMENT
DESC: The version of OpenSSL linked to the release artifacts was updated to 3.1.4, and moving forward will be synced to the vcpkg builtin-baseline.

@KiterLuc KiterLuc merged commit 493e3f9 into dev Jul 13, 2024
63 checks passed
@KiterLuc KiterLuc deleted the teo/openssl-3 branch July 13, 2024 04:52
@eddelbuettel
Copy link
Contributor

@teo-tsirpanis This looks like minor noise but why am I getting it?

-- Installing port from location: /home/edd/git/vcpkg/buildtrees/versioning_/versions/openssl/5ee74387a1dd212dc9754c614809ff86bd0638fa
-- Downloading https://github.com/openssl/openssl/archive/openssl-3.1.4.tar.gz -> openssl-openssl-openssl-3.1.4.tar.gz...
-- Extracting source /home/edd/git/vcpkg/downloads/openssl-openssl-openssl-3.1.4.tar.gz
-- Applying patch disable-apps.patch
-- Applying patch disable-install-docs.patch
-- Applying patch script-prefix.patch
-- Applying patch windows/install-layout.patch
-- Applying patch windows/install-pdbs.patch
-- Applying patch unix/android-cc.patch
-- Applying patch unix/move-openssldir.patch
-- Applying patch unix/no-empty-dirs.patch
-- Applying patch unix/no-static-libs-for-shared.patch
-- Using source at /home/edd/git/vcpkg/buildtrees/openssl/src/nssl-3.1.4-c5488d00d9.clean
openssl requires Linux kernel headers from the system package manager.
   They can be installed on Alpine systems via `apk add linux-headers`.
   They can be installed on Ubuntu systems via `apt install linux-libc-dev`.

-- Getting CMake variables for x64-linux

I (of course) have linux-libc-dev installed here. Is this 'merely' vcpkg talking to me telling that there are things it cannot get (and where it doesn't need to talk to me because I ... already have them?

@teo-tsirpanis
Copy link
Member Author

teo-tsirpanis commented Jul 13, 2024

I saw this too, vcpkg always prints it. https://github.com/microsoft/vcpkg/blob/1de2026f28ead93ff1773e6e680387643e914ea1/ports/openssl/unix/portfile.cmake#L1-L7

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants