Stop recognizing sm.use_refactored_readers config option.
#5183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option has been deprecated and undocumented for a while and a warning was emitted if it is used. Refactored readers are used by default. To use the legacy reader, users have to set the `sm.query_(dense|sparse_global_order|sparse_unordered_with_dups)_reader` config option to `legacy`.
KiterLuc
approved these changes
Jul 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-50445
This option has been deprecated and undocumented for a while and a warning was emitted if it is used. This PR removes all mentions of it from the codebase.
TYPE: CONFIG
DESC: The
sm.use_refactored_readersconfig option is no longer recognized. Refactored readers are used by default. To use the legacy reader, set thesm.query_(dense|sparse_global_order|sparse_unordered_with_dups)_readerconfig option (depending on the reader you are using) tolegacy.