Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable array open v2 and query v3 by default. #5207

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

ypatia
Copy link
Member

@ypatia ypatia commented Jul 22, 2024

[sc-47320]

This PR just changes the two configuration variables that toggle "Array open v2" and "Query v3" features to ON by default.


TYPE: FEATURE
DESC: Enable array open v2 and query v3 by default.

@ypatia ypatia requested a review from a team as a code owner July 22, 2024 12:56
@KiterLuc KiterLuc merged commit ea0a866 into dev Jul 22, 2024
62 checks passed
@KiterLuc KiterLuc deleted the yt/enable_query_v2_by_default branch July 22, 2024 14:29
@KiterLuc
Copy link
Contributor

/backport to release-2.25

Copy link
Contributor

Started backporting to release-2.25: https://github.com/TileDB-Inc/TileDB/actions/runs/10042811317

Copy link
Contributor

@KiterLuc backporting to release-2.25 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Enable array open v2 and query v3 by default.
Using index info to reconstruct a base tree...
M	tiledb/api/c_api/config/config_api_external.h
M	tiledb/sm/cpp_api/config.h
Falling back to patching base and 3-way merge...
Auto-merging tiledb/sm/cpp_api/config.h
CONFLICT (content): Merge conflict in tiledb/sm/cpp_api/config.h
Auto-merging tiledb/api/c_api/config/config_api_external.h
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Enable array open v2 and query v3 by default.
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor

@KiterLuc an error occurred while backporting to release-2.25, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

KiterLuc pushed a commit that referenced this pull request Jul 22, 2024
[[sc-47320](https://app.shortcut.com/tiledb-inc/story/47320)]

This PR just changes the two configuration variables that toggle "Array
open v2" and "Query v3" features to ON by default.

---
TYPE: FEATURE
DESC: Enable array open v2 and query v3 by default.
KiterLuc added a commit that referenced this pull request Jul 22, 2024
…#5207) (#5208)

Backport of #5207 to release-2.25.

---
TYPE: FEATURE
DESC: Enable array open v2 and query v3 by default.

Co-authored-by: Ypatia Tsavliri <ypatia@tiledb.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants