Switch to more modern async idioms #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, hope it doesn't break anyone unintentionally. Can you add a changelog entry? |
I converted AiofilesContextManager to an awaitable from a coroutine, and the interface was simplified as a result. In addition to that, open is now a proper async function and types.coroutine is not used anymore.
onlined
force-pushed
the
modern-async
branch
from
f1fea1f
to
1eaa34e
Compare
|
Thanks! Added the entry. |
|
@Tinche kind reminder |
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted
AiofilesContextManagerto an awaitable from a coroutine, and the interface was simplified as a result. In addition to that,openis now a proper async function andtypes.coroutineis not used anymore.