Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updated config and how to load dependencies #30

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

skourta
Copy link
Collaborator

@skourta skourta commented Oct 10, 2024

This pull request includes several changes aimed at simplifying the configuration process, updating documentation, and improving code consistency. The most important changes include updates to the configuration format, refactoring import statements, and adding new linting tools configuration.

Configuration and Documentation Updates:

  • .github/workflows/python-package.yml: Updated the build and install paths to use ${INSTALL_PATH}, and modified the config.yaml creation to reflect the new dependency structure.
  • README.md: Updated the config.yaml format to replace tiramisu and env_vars with dependencies, includes, and libs. Also, refactored import statements to simplify the configuration module import. [1] [2] [3] [4] [5] [6]
  • config.yaml.example: Updated the example configuration file to match the new format.

Code Refactoring:

Linting Tools Configuration:

  • pyproject.toml: Added configuration for linting tools such as Ruff and Codespell, and specified rules and exceptions for code quality checks.

Code Consistency Improvements:

  • tests/tiramisu/test_schedule.py, tests/tiramisu/test_tiramisu_server.py, tests/tiramisu/tiramisu_actions/test_distribution.py, tests/tiramisu/tiramisu_actions/test_expansion.py, tests/tiramisu/tiramisu_actions/test_matrix.py: Made minor adjustments to method calls and assertions to improve code consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9]

These changes collectively enhance the maintainability and readability of the codebase while ensuring that the configuration process is more straightforward and well-documented.

@skourta skourta merged commit d2f1584 into main Oct 10, 2024
2 checks passed
@skourta skourta deleted the config-change-compile-simplification branch October 10, 2024 05:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant