Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

Broken animated icon for running jobs #40

Closed
kjyv opened this issue Mar 11, 2021 · 20 comments · Fixed by #48
Closed

Broken animated icon for running jobs #40

kjyv opened this issue Mar 11, 2021 · 20 comments · Fixed by #48
Labels

Comments

@kjyv
Copy link

kjyv commented Mar 11, 2021

Since Jenkins 2.283 (jenkinsci/jenkins#5065), the animation looks quite weird, an extra arrow circle is rotating around the icon itself.

@wahammed
Copy link

Is this issue fixed/addressed? I'm facing the same issue.

image

@kjyv
Copy link
Author

kjyv commented Mar 30, 2021

Doesn't look like any updates have been committed

@TobiX
Copy link
Owner

TobiX commented Mar 30, 2021

Yes, I haven't come around to fixing the issue yet. It's not a high priority for me, since I don't use Jenkins weeklies.

@TobiX TobiX added the bug label Mar 30, 2021
@kjyv
Copy link
Author

kjyv commented Mar 30, 2021

Not sure what you're implying but they are not weeklies as in nightlies. They are the normal stable releases including security patches (although released quite often) and they go through all normal release channels, so package managers are updating jenkins to theses versions etc. So it is an issue for all your normal users. And since your theme seems to be the nicest one I'd guess there are quite a few :)

@iridinite
Copy link

I can confirm that this is a problem on the stable release version 2.285. Would love to see a fix!

Incidentally, the new official icons aren't half bad -- could be interesting to reuse parts of it maybe, like the spinning animation?

@obayit
Copy link

obayit commented Apr 18, 2021

I am also facing the same issue, sadly I had to uninstall the theme because of this.

@rammie
Copy link

rammie commented May 7, 2021

Seeing the same issue. Would you accept a PR?

@TobiX
Copy link
Owner

TobiX commented May 7, 2021

Sure, PRs are always welcome!

@TobiX TobiX closed this as completed in #48 May 8, 2021
TobiX pushed a commit that referenced this issue May 8, 2021
@luebbe
Copy link

luebbe commented May 27, 2021

This is still not 100% fixed. The animated spinner for "not yet run" jobs is wrong:

grafik
job page

grafik
plugin update page

@wahammed
Copy link

wahammed commented May 28, 2021

image

This issue is not fixed yet. Version : Jenkins 2.295

@TobiX
Copy link
Owner

TobiX commented May 28, 2021

PRs welcome.

@TobiX TobiX reopened this May 28, 2021
@luebbe
Copy link

luebbe commented May 31, 2021

Maybe @rammie can fix this one too? I tried to figure out the icon's class using FF inspector but didn't have success in all cases. It probably is icon-disabled, but I could only confirm this on the tasks screen, not on the updates screen.

@wahammed
Copy link

wahammed commented Jun 2, 2021

Another observation, This works fine with freestyle or pipeline jobs but not with Multibranch Pipeline.

@33man
Copy link

33man commented Jun 4, 2021

Another observation, This works fine with freestyle or pipeline jobs but not with Multibranch Pipeline.

Yep I confirm that.

@tynril
Copy link

tynril commented Jun 5, 2021

It looks like it's also broken with pipeline jobs if they are located in a folder.

@andytrofimov
Copy link

andytrofimov commented Jun 9, 2021

@TobiX I'v also submitted a pr to fix animation for all remaining build statuses

@TobiX
Copy link
Owner

TobiX commented Jun 9, 2021

The root cause is that https://github.com/TobiX/jenkins-core-theme isn't prepared to work with SVG icons yet and makes some stupid assumptions about Jenkins icons. I'll keep this issue open until I come around to properly fixing all the icons for never Jenkins versions.

@ksangam
Copy link

ksangam commented Nov 3, 2021

Has this been fixed? I see this double rotating icon with LTS version 2.303.2 as well.

@33man
Copy link

33man commented Nov 3, 2021

Has this been fixed? I see this double rotating icon with LTS version 2.303.2 as well.

Hmm working here with v0.6

@virgo47
Copy link

virgo47 commented May 25, 2022

It reappeared when upgrading from 2.347 to 2.349 in our case.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.