Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add an "int16" property type #1358

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Add an "int16" property type #1358

merged 3 commits into from
Mar 29, 2024

Conversation

sgillies
Copy link
Member

@sgillies sgillies commented Mar 12, 2024

Resolves #1321

I might like to improve how the project enumerates its data types too.

@sgillies sgillies added the bug label Mar 12, 2024
@sgillies sgillies added this to the 1.10 milestone Mar 12, 2024
@sgillies sgillies self-assigned this Mar 12, 2024
@sgillies sgillies requested a review from mwtoews March 13, 2024 21:11
@sgillies
Copy link
Member Author

@mwtoews any thoughts on this?

@mwtoews
Copy link
Member

mwtoews commented Mar 17, 2024

Sure, some questions / remarks:

  • Should int16 be described in this doc or specifically fiona.FIELD_TYPES_MAP? (also bool is missing here too, so I'm not entirely sure if this subdata type should be added there.)
  • Currently fiona.schema.normalize_field_type("int16") returns int32; should it? The same function with bool returns bool.

@sgillies
Copy link
Member Author

@mwtoews thank you! I'll check on the function, that looks like a bug.

@sgillies
Copy link
Member Author

@mwtoews I'm going to address your concerns in a follow up PR.

@sgillies sgillies merged commit 42ed681 into main Mar 29, 2024
8 checks passed
@sgillies sgillies deleted the issue1321 branch March 29, 2024 21:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write columns with "short" type in gdb with OpenFileGDB driver
2 participants