-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bring onboard filter, map, and reduce from fio-planet #1362
Conversation
With some refactoring and conditional enablement of commands that require shapely.
@mwtoews do you have any comments on the new documentation? I think it looks okay and that this PR is ready for a final review. I feel good about allowing the new and old filter expressions to live side-by-side for a while. https://fiona--1362.org.readthedocs.build/en/1362/cli.html#filter |
@snorfalorpagus @perrygeo any objections to this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snuggs for vector data! Looks good and provides a better DSL than the old python expressions. I'm curious too see how far people can push this... writing an entire analysis pipeline with snuggs seems feasible.
Some Lisp programmers might have a heart attack at the optional outer parens but I think it makes the CLI easier on the eyes. +1
I'm not 100% clear on the logic for differentiating the type of expression. I'm imagining a case where the syntax is ambiguous and a previously valid python expression gets misinterpreted as a snuggs expression. I don't have a good example though, probably not an issue.
Looks great!
With some refactoring and conditional enablement of commands that require shapely.
TODO:
Resolves #1327