Restore behavior of setting fields to values derived from date, time #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillies
commented
Apr 15, 2024
sgillies
commented
Apr 15, 2024
| val_type = type(value) | ||
|
|
||
| if val_type in self.property_setter_cache: | ||
| setter = self.property_setter_cache[val_type] |
There was a problem hiding this comment.
In a nutshell: the code in 1.9 tested elif isinstance(value, (date, time, datetime) before calling a field setter. In 1.10 we will register setters to names like "date" and use the MRO of type(value) to look up and cache a setter.
There was a problem hiding this comment.
Look okay to you @mwtoews ?
* This is 1.10a2 * Rename VSI plugin prefix Resolves #1369 * This is 1.10b1.dev0
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1376