Toggle value not updated when it's reset from a binding

[MaxDesiatov]

Previously reported by @rbartolome. Here's a reproducible test case:

class TestData: ObservableObject
{
    @Published var stringData: String = ""
    @Published var booleanData: Bool = false
    
    func reset()
    {
        self.stringData = ""
        self.booleanData = false
    }
}

struct DemoToggle: App
{
    @ObservedObject var testdata = TestData()
    var body: some Scene
    {
        WindowGroup("DemoTracker")
        {
            VStack
            {
                Toggle("Toogle", isOn: self.$testdata.booleanData)
                TextField("Placeholder", text: self.$testdata.stringData)
                Button(action:
                {
                    self.testdata.reset()
                },
                label:
                {
                    Text("Reset")
                })
            }
        }
    }
}

DemoToggle.main()

[RayZhao1998]

It seems that checked.toggle() can't update the Toggle value too.

Full code:

public struct ToggleDemo: View {
  @State var checked = false

  public var body: some View {
    VStack {
      Toggle("Toogle", isOn: $checked)
      Text(checked ? "Checked" : "Not Checked")
      Button(action:
      {
        self.checked.toggle()
      },
      label:
      {
          Text("Reset")
      })
    }
  }
}

[RayZhao1998]

Found the reason. The checkbox in HTML is so weird. Whether it's checked is not determined by the checked property. Even though I uncheck the checkbox, the property checked="checked" is still there.

[MaxDesiatov]

Thanks for the investigation! Now I remember something similar was mentioned during review when @j-f1 was working on #159.

[RayZhao1998]

Usually we uncheck the checkbox in JS like getElementsByTagName('input')[0].checked = false.

I find a modifier: _domRef. Can we get the input DOM and set its checked?

[MaxDesiatov]

@RayZhao1998 a fix for this was included as a part of the latest 0.5.3 release. _domRef wasn't needed after all 🙂