Two infinite loop fixes #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of these issues are fixes to `CustomStringConvertible` implementations that either directly or indirectly called themselves via `String(describing:)`.
MaxDesiatov
approved these changes
Jan 19, 2021
Yup! Sadly there still seems to be at least one more infinite loop somewhere, but these I've identified and allowed me to move forward. Hopefully I'll find the remaining ones soon. They only happen after the app sits idle; much more difficult to find. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these issues are fixes to
CustomStringConvertibleimplementations that either directly or indirectly called themselves viaString(describing:).I'm not sure what is expected to be presented in these
descriptionimplementations, so please review and let me know if you would like alternative implementations.