Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added TextField support for GTK using GtkEntry #361

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

mortenbekditlevsen
Copy link
Contributor

Note, that in the 'update' block I do not disconnect and reconnect the signal as it is done in the gtk Button implementation.
I am a bit uncertain whether or not that is actually needed in some special case.
If it's not needed, perhaps it can be removed from the Button implementation too.

@mortenbekditlevsen mortenbekditlevsen requested a review from a team January 19, 2021 10:44
@mortenbekditlevsen mortenbekditlevsen added the GTK renderer Extending GTK support label Jan 19, 2021
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 👍

@mortenbekditlevsen mortenbekditlevsen merged commit 9199a90 into main Jan 19, 2021
@mortenbekditlevsen mortenbekditlevsen deleted the gtk-textfield branch January 19, 2021 11:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
GTK renderer Extending GTK support
Development

Successfully merging this pull request may close these issues.

2 participants