Add a benchmark target and a script to run it #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks need to be built in the release mode, that's why I created a separate `benchmark.sh` script to build it and run it. I've also cleaned up a compiler warning in `TextEditor.swift` and bumped macOS agents to use Xcode 12.3 instead of 12.2.
MaxDesiatov
added
the
continuous integration
carson-katri
previously approved these changes
Jan 20, 2021
|
Just a trivial change to fix the buld, so I'm assuming that the previous review approval still holds 🙂 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks need to be built in the release mode, I created a separate
benchmark.shscript to build it and run it.I've also cleaned up a compiler warning in
TextEditor.swiftand bumped macOS agents to use Xcode 12.3 instead of 12.2After this is merged to
mainI want to set it up an similarly to what we have in JavaScriptKit where benchmarks run on both a PR branch andmainand difference between them is posted as a comment.