Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add ContainerRelativeShape #416

Merged
merged 5 commits into from
Jul 7, 2021
Merged

Add ContainerRelativeShape #416

merged 5 commits into from
Jul 7, 2021

Conversation

carson-katri
Copy link
Member

This adds ContainerRelativeShape and a containerShape modifier. It does not correctly handle the position of Views, as GeometryProxy doesn't provide access to View frames, only bounds.

@carson-katri carson-katri added the SwiftUI compatibility Tokamak API differences with SwiftUI label Jul 7, 2021
MaxDesiatov
MaxDesiatov reviewed Jul 7, 2021
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems legit. 👍
Could this have a run of swiftformat to resolve warnings, and also a snapshot test added?

MaxDesiatov
MaxDesiatov approved these changes Jul 7, 2021
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@carson-katri carson-katri merged commit 79a9a66 into main Jul 7, 2021
@carson-katri carson-katri deleted the container-relative-shape branch July 7, 2021 17:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
SwiftUI compatibility Tokamak API differences with SwiftUI
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carson-katri @MaxDesiatov