Add controlSize/controlProminence modifiers #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carson-katri
added
DOM/HTML renderer
|
Would it be possible to somehow conditionally use |
|
I used
|
MaxDesiatov
approved these changes
Jul 19, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
controlSizeandcontrolProminencemodifiers, as well as styles for Button that use them.I used the
default-buttonappearance which works in Safari for increased prominence buttons, but this isn't supported in other browsers. I can switch it to use custom CSS, but then it may look out of place with other browser buttons...