-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bump requirements to Swift 5.4, migrate to @resultBuilder
#442
Conversation
@resultBuilder
We can switch back to the Swift 5.4 version of SwiftLint now. You can use |
Getting some new warnings:
Can be fixed by switching to
I'm not exactly sure what's going on here. Seems to no longer be an issue with Xcode 13, so could just ignore for now.
Know which flags are the problem here?
Looks like a carton issue. |
Done
Yup, I have no idea either, doesn't look critical at the moment
Not sure, nothing's changed on that front in Tokamak codebase, I suspect some updates to SwiftPM in Swift 5.4 could be the culprit.
Fixed in swiftwasm/carton#257 I assume all warnings that could be resolved in Tokamak are resolved here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, looks good.
This updates the project to use Swift 5.4 across all platforms. Swift 5.4 is now also the required version, which allows us to use
@resultBuilder
instead of the deprecated version of this attribute from Swift 5.3.Use
carton
0.11.0 or later from now on to build with SwiftWasm 5.4.0.