-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add _ShapeView
and background
modifiers support to Fiber renderers
#491
Conversation
@@ -183,3 +223,54 @@ extension _ShapeView: _HTMLPrimitive { | |||
} | |||
} | |||
} | |||
|
|||
@_spi(TokamakStaticHTML) extension _ShapeView: HTMLConvertible { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: let's keep declaration attributes consistently on a separate line
@_spi(TokamakStaticHTML) extension _ShapeView: HTMLConvertible { | |
@_spi(TokamakStaticHTML) | |
extension _ShapeView: HTMLConvertible { |
Is |
Yes, exactly. Its the equivalent to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small formatting nits, otherwise seems legit 👍
snapshot tests are failing though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit, thanks!
This adds support for
_ShapeView
and related styling, as well as the variousbackground
modifiers to the Fiber renderers:Overriding View Bodies
It also introduces the capability to override the body of a View in a specific Fiber renderer using the
visitPrimitiveChildren
protocol requirement onFiberRenderer
:In this function, we can optionally return a new function that will override the default
_visitChildren
function on theView
.