parsing env vars in scripts #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // check for environment variables inside script | ||
| if !strings.Contains(s, "$$") { | ||
| continue |
There was a problem hiding this comment.
Instead of using continue and a negated condition why not just insert the replaceEnvs here?
There was a problem hiding this comment.
Initially I had all the logic in here and didn't want all the nesting. I wouldn't mind moving replaceEnv to this line.
The code looks for env vars to start with '2729' instead of just a single '$' no matter the operating system.
zabawaba99
force-pushed
the
env-parsing
branch
from
d1b2d3d to
6d9d56f
Compare
|
👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code looks for env vars to start with '2729' instead of just a single '$' no matter the operating system.
resolves #42
TODO: