This repository was archived by the owner on May 5, 2023. It is now read-only.
Uncaught TypeError: Cannot read property 'socket' of undefined #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Halåj, this is a patch for a bug when a connection fails we are trying to access a property on the undefined
result
object instead of first handling the actual connection error.Opened an issue for this also in case others have same problem: #19
fix for
Uncaught TypeError: Cannot read property 'socket' of undefined
bugfix:
Cannot read property 'socket' of undefined
error:
Uncaught TypeError: Cannot read property 'socket' of undefined
description:
handle connection error first before attempting to get result.socket
result will be undefined if there is a connection error, and instead
of handling the connection error, we will crash on trying to reference
socket from an 'undefined' result object