Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[NU-1740] README #2

Merged
merged 7 commits into from
Sep 3, 2024
Merged

[NU-1740] README #2

merged 7 commits into from
Sep 3, 2024

Conversation

mk-software-pl
Copy link
Collaborator

No description provided.

Copy link
Contributor

@lukasz-bigorajski lukasz-bigorajski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

README.md Outdated

#### Using Scenario Examples Bootstrapper with scenario defined outside

You don't have to put your scenario is the Library to be able to use it with the Scenario Examples Bootstapper. All you need to do is to mount
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: in?

│ ├── mocks # mock definitions (optional)
│ │   └── db
│ │   ├── {db-schema-02-name}.sql # script with DDLs to import
│ │   └── {db-schema-02-name}.sql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there 2 times the same DDL?

README.md Outdated
#### DB mocks

DB mocks should be added to the `{scenario-name}/mocks/db` folder. The mocks has a form of PostgreSQL DDL scripts. Name of the script will
be used a schema in the database (all scripts will be run in context of the same PostgreSQL db instance).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a schema?

README.md Outdated

#### OpenAPI mocks

OpenAPI mocks should be added in the `{scenario-name}/mocks/http-service` folder. Mock for singe API contains the service OpenAPI definition (placed in the `{scenario-name}/mocks/http-service/{service-name}/__files/{service-name}/openapi` folder) and Wiremock's mappings (placed in the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single?

README.md Outdated
```
</details>

# todo:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this?

Copy link
Contributor

@lukasz-bigorajski lukasz-bigorajski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mk-software-pl mk-software-pl merged commit 0ce2fb7 into master Sep 3, 2024
1 check passed
@mk-software-pl mk-software-pl deleted the readme/NU-1740 branch September 3, 2024 07:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants