-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[NU-1740] README #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
README.md
Outdated
|
||
#### Using Scenario Examples Bootstrapper with scenario defined outside | ||
|
||
You don't have to put your scenario is the Library to be able to use it with the Scenario Examples Bootstapper. All you need to do is to mount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: in
?
│ ├── mocks # mock definitions (optional) | ||
│ │ └── db | ||
│ │ ├── {db-schema-02-name}.sql # script with DDLs to import | ||
│ │ └── {db-schema-02-name}.sql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there 2 times the same DDL?
README.md
Outdated
#### DB mocks | ||
|
||
DB mocks should be added to the `{scenario-name}/mocks/db` folder. The mocks has a form of PostgreSQL DDL scripts. Name of the script will | ||
be used a schema in the database (all scripts will be run in context of the same PostgreSQL db instance). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a schema
?
README.md
Outdated
|
||
#### OpenAPI mocks | ||
|
||
OpenAPI mocks should be added in the `{scenario-name}/mocks/http-service` folder. Mock for singe API contains the service OpenAPI definition (placed in the `{scenario-name}/mocks/http-service/{service-name}/__files/{service-name}/openapi` folder) and Wiremock's mappings (placed in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
single
?
README.md
Outdated
``` | ||
</details> | ||
|
||
# todo: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.