Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix bug after porting tab manager #1340

Merged
merged 9 commits into from
Mar 19, 2025
Merged

Fix bug after porting tab manager #1340

merged 9 commits into from
Mar 19, 2025

Conversation

JYC333
Copy link
Contributor

@JYC333 JYC333 commented Mar 5, 2025

  • Revert "Revert "port tab manager to ts""
  • fix: 🐛 fix wrong triggerEvent usage
  • refactor: 💡 refactor serval event names
  • fix: 🐛 can't move a tab to new window

Branch is messed up, so create a new branch and a new PR.
Previous PR: #1330

@JYC333 JYC333 marked this pull request as draft March 5, 2025 13:08
@JYC333
Copy link
Contributor Author

JYC333 commented Mar 5, 2025

@eliandoran I change the test:playwright to npx playwright test (which is defined in action yaml) and run it locally in develop, still get 7 errors

7 failed
    [chromium] › e2e/note_types/code.spec.ts:4:1 › Displays lint warnings for backend script ───────
    [chromium] › e2e/note_types/mermaid.spec.ts:4:1 › renders ELK flowchart ────────────────────────
    [chromium] › e2e/note_types/mermaid.spec.ts:29:1 › renders standard flowchart ──────────────────
    [chromium] › e2e/note_types/mindmap.spec.ts:4:1 › displays simple map ──────────────────────────
    [chromium] › e2e/note_types/text.spec.ts:4:1 › Table of contents is displayed ──────────────────
    [chromium] › e2e/note_types/text.spec.ts:39:1 › Highlights list is displayed ───────────────────
    [chromium] › e2e/note_types/text.spec.ts:53:1 › Displays math popup ────────────────────────────

And I run it on my branch here, get 6 errors

6 failed
    [chromium] › e2e/note_types/code.spec.ts:4:1 › Displays lint warnings for backend script ───────
    [chromium] › e2e/note_types/code.spec.ts:24:1 › Displays lint errors for backend script ────────
    [chromium] › e2e/note_types/mermaid.spec.ts:4:1 › renders ELK flowchart ────────────────────────
    [chromium] › e2e/note_types/mermaid.spec.ts:29:1 › renders standard flowchart ──────────────────
    [chromium] › e2e/note_types/mindmap.spec.ts:4:1 › displays simple map ──────────────────────────
    [chromium] › e2e/note_types/mindmap.spec.ts:14:1 › displays note settings ──────────────────────

But in Github Action it gets 10 fails. Maybe you something behind this?

@JYC333 JYC333 force-pushed the fix_tab branch 3 times, most recently from 6952e51 to 7c1d63f Compare March 18, 2025 17:52
@JYC333 JYC333 marked this pull request as ready for review March 18, 2025 21:06
@JYC333 JYC333 requested a review from eliandoran March 18, 2025 21:10
@eliandoran eliandoran merged commit 716f8ec into develop Mar 19, 2025
5 checks passed
@eliandoran eliandoran deleted the fix_tab branch March 19, 2025 18:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants