Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make attachments open in a new tab/browser #559

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

SiriusXT
Copy link
Contributor

@SiriusXT SiriusXT commented Nov 6, 2024

Related to #553.

  1. The changes in abstract_text_type_widget.js allow images to open in a new tab when holding down the Ctrl key.

  2. It’s unclear why configureWebContents was originally executed only in the main window within src/services/window.ts, which prevented configureWebContents from working properly in the extra window. Therefore, I removed:

if (!mainWindow) {
    return;
}

because it prevented extraWindow from opening links in the browser.

@eliandoran eliandoran merged commit b5988ba into develop Nov 7, 2024
1 check passed
@eliandoran eliandoran deleted the siriusxt-test branch November 7, 2024 20:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants