Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Native title bar buttons #702

Merged
merged 44 commits into from
Dec 6, 2024
Merged

Native title bar buttons #702

merged 44 commits into from
Dec 6, 2024

Conversation

eliandoran
Copy link
Contributor

@eliandoran eliandoran commented Dec 1, 2024 •
edited
Loading

When native title bar is off, the original implementation drew its own buttons for minimizing, maximizing and closing the window. There are a few disadvantages with this:

  1. The buttons look off on all platforms (Windows where the icons were too thick, macOS where the icons were on the wrong side).
  2. Some native functions were not available, for example hovering on the maximize button will display additional layout options on Windows.
  3. On Linux, kept the original title bar buttons (at least for now) due to inconsistencies on wayland with the overlay button icons.

Windows

Before:

image

After:

image

macOS

Before:

image

After:

image

Position of the pin

The pin button has been relocated to the contextual menu, since we can no longer add extra buttons.

image

@eliandoran
feat(electron): enable native window buttons on frameless
0089346
@eliandoran
feat(electron): set overlay information at runtime
6019297
@eliandoran
feat(electron): load overlay information from CSS
0151215
@eliandoran
feat(electron): relocate pin to global menu
bd890c4
@eliandoran
Merge remote-tracking branch 'origin/develop' into feature/native_win…
Loading
Loading status checks…
12f54a6 
…dow_buttons
@eliandoran
fix(client): build error due to non-existing import
Loading
Loading status checks…
d05c1de
@eliandoran
Merge remote-tracking branch 'origin/develop' into feature/native_win…
Loading
Loading status checks…
819a6d2 
…dow_buttons
@eliandoran
Merge remote-tracking branch 'origin/develop' into feature/native_win…
Loading
Loading status checks…
e9aba03 
…dow_buttons
@eliandoran
Merge remote-tracking branch 'origin/develop' into feature/native_win…
Loading
Loading status checks…
229825d 
…dow_buttons
@eliandoran
fix(native-buttons): enable buttons on other windows as well
45faa66
@eliandoran
feat(native-buttons): watch for theme changes
5761320
@eliandoran
theme(next): make subtle border color less subtle on dark mode
9e0546d
@eliandoran
fix(electron): fix regression when native title bar is on
28b27f0
@eliandoran
fix(native-buttons): right margin
c06ff4e
@eliandoran
chore(i18n): remove period for menu item
95664ad
@eliandoran
chore(i18n): fix capitalization
Loading
Loading status checks…
e933b8d
@eliandoran
feat(native-buttons): differentiate background based on layout
8135fa0
@eliandoran
style(next): fix title bar background
29fb9f4
@eliandoran
style(next): fix title bar background on classical themes
Loading
Loading status checks…
d472a00
@eliandoran
feat(native-buttons): apply inset style for macOS
07beeda
@eliandoran
feat(style): pass platform to CSS
e9cf310
@eliandoran
feat(style): pass whether electron to CSS
7cb5ef2
@eliandoran
fix(native-buttons): fix left margin on darwin
b32eef9
@eliandoran
refactor(native-buttons): reduce duplication
14fb8b5
@eliandoran
feat(native-buttons): apply full width regardless
8d2a8ea
@eliandoran
feat(native-buttons): allow drag behind title area
9d98c4a
@eliandoran
fix(native-buttons): double left pane toggle widget
cd8c596
@eliandoran
feat(native-buttons): set arbitrary offset for traffic light
00c6d97
@eliandoran
feat(native-buttons): adjustable offset
05c5109
@eliandoran
style(next): adjust offset for native title bar buttons
5c09b2d
@eliandoran eliandoran marked this pull request as ready for review December 6, 2024 22:23
@eliandoran eliandoran merged commit e22e974 into develop Dec 6, 2024
3 checks passed
@eliandoran eliandoran deleted the feature/native_window_buttons branch December 6, 2024 22:43
@eliandoran eliandoran restored the feature/native_window_buttons branch December 14, 2024 06:56
@eliandoran eliandoran deleted the feature/native_window_buttons branch December 14, 2024 06:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eliandoran