Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

i18n: make <kbd> tags translatable #857

Merged
merged 14 commits into from
Dec 29, 2024

Conversation

pano9000
Copy link
Member

Hello,

This fixes #820, by moving the tags into the translation strings.

What I did NOT do though, is fix the keyboard commands that come from the keyboard_actions file – I've opened up a separate issue for this, as it requires a different approach IMHO than for these tags here.

I tried to move the kbd tags into the current translations as well, using previously used translations of these kbd tags as reference where possible.

Copy link
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good start for now.

There are still things that moving keyboard shortcuts into translation won't solve, such as rewriting Super into ⌘ for macOS, but we can deal with them later.

Ideally for me, the shortcut keys should be a separate field for context menus and the shortcut is translated via a service (which will split it into components, but also apply platform-specific changes such as the previously mentioned super key).

@eliandoran eliandoran merged commit 42c6c44 into TriliumNext:develop Dec 29, 2024
@pano9000 pano9000 deleted the feat_i18n-kdb-tags-#820 branch December 29, 2024 10:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n: <kbd> tags should be translatable as well
2 participants