i18n: make duplicate notes suffix translatable #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR makes the "(dup)" suffix for duplicated notes translatable.
Previously this was fully hardcoded as " (dup)", now we can translate it, using
notes.duplicate-note-suffix.I've also added support for RTL languages by allowing the translators to decide where the suffix should be placed:
For LTR languages it will be at the "right end" of the string, for RTL languages it will be at the "left end" of the string.
This is using
notes.duplicate-note-title.To keep the same functionality as before for RTL langs (where the suffix is only added once for a note, even if there are several clones), I expanded the
res.note.titlecheck to also check forstartsWith.Since majority of languages are LTR, I've kept the "endsWith" check as first check, so that we can make use of short-circuiting.
I did not update the existing translations with these new translation keys though – this way these will still keep the English translation until they get properly translated.
Closes #825