This repository has been archived by the owner on Aug 5, 2020. It is now read-only.
hotfix #1039 - set cookie after headers sent errors #1040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethbattin
force-pushed
the
bug/trap-httpclient-errors
branch
from
88bebb4 to
a53e98e
Compare
sethbattin
force-pushed
the
bug/trap-httpclient-errors
branch
from
a53e98e to
641ad3e
Compare
|
I spoke with @sethbattin and we determined this was no longer needed. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change catches and logs the errors I observed in #1039 It does not address the root cause of the cookie issues.
See my comment here for the truecar code that exposes this error: #1039 (comment)