Improve SVG conversion. #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adjusted and extended the ‘convert-images.lua’ script to handle SVG conversions (including *.drawio.svg) with 'rsvg-convert', which is faster (and better) than using drawio (produces garbage sometimes). * Made the 'string:hassuffix' function case-insensitive, and added 'jpeg' and 'webp' images types. * Added 'librsvg2-bin' package to Dockerfile (for 'rsvg-convert' tool). * Minor indentation fix in 'informative-quote-blocks.lua'. Signed-off-by: Michael Eckel <michael.eckel@sit.fraunhofer.de>
|
I'd be fine changing the tool used for converting regular svgs, but drawio svgs are special and should be rendered using drawio to ensure that the final document looks as drawio says it will. I think drawio supports embedding the drawio metadata into a png, which could be a better experience. I'm planning to experiment with that and see if it works better. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207.
Improved SVG conversion:
Adapted and extended the
convert-images.luascript to handle SVG conversions (including*.drawio.svg) withrsvg-convert, which is faster (and better!?) than using draw.io (which sometimes produces garbage: missing and skewed arrows and elements, wrong overlaps, etc.).Added the package
librsvg2-binto the Dockerfile (for the toolrsvg-convert)The
string:hassuffixfunction is no longer case-sensitive.Added support for image types
jpegandwebpMinor indentation fix in
informative-quote-blocks.lua