Removed duplicate method for fetching default account #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike182uk
reviewed
Jan 27, 2025
allouis
force-pushed
the
remove-duplicate-method
branch
from
d6db946 to
4a77f92
Compare
allouis
force-pushed
the
remove-duplicate-method
branch
from
4a77f92 to
4311b53
Compare
Whilst we were building out the infrastructure for accounts and sites we ended up with some duplicate code, this consolidates it into the account service, slightly updating the signature to never resolve with null, throwing if an account is not found instead. We also clean up all the call sites and tests.
allouis
force-pushed
the
remove-duplicate-method
branch
from
4311b53 to
c52fbb4
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst we were building out the infrastructure for accounts and sites we ended up with some duplicate code, this consolidates it into the account service, slightly updating the signature to never resolve with null, throwing if an account is not found instead. We also clean up all the call sites and tests.