Skip to content

switch to prebuild for better binary distribution and electron support #1641

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
gpetrov opened this issue Oct 3, 2022 · 4 comments
Closed

switch to prebuild for better binary distribution and electron support #1641

gpetrov opened this issue Oct 3, 2022 · 4 comments
Labels
feature request

Comments

@gpetrov
Copy link

gpetrov commented Oct 3, 2022 •
edited
Loading

Summary

Currently node-sqlite3 uses node-pre-gyp for building and delivers only node compatible modules.

Proposed implementation

To achieve wider binary distribution and to support electron prebuild binaries, a support for prebuild is desired.

See https://nodejs.github.io/node-addon-examples/build-tools/prebuild/
@gpetrov
Copy link
Author

gpetrov commented Oct 3, 2022

Also node-pre-gyp is hitting a bit of a dead-end. See mapbox/node-pre-gyp#657

@daniellockyer
Copy link
Member

I'm also coming to the same conclusion 🙂 I'd like to serve armv6 and armv7 but I ran into a bug with node-pre-gyp: mapbox/node-pre-gyp#348 (comment)

I'd welcome a PR to change over to prebuild. Else I can look at changing this but I have no ETA on that right now

@daniellockyer
Copy link
Member

That being said, it doesn't look like it would solve my problem: prebuild/prebuild#174

daniellockyer added a commit that referenced this issue Dec 24, 2023
@daniellockyer
Replaced @mapbox/node-pre-gyp in favor of prebuild + `prebuild-in…
513bace 
…stall`

fixes #1641
fixes #1721
fixes #1714
fixes #1713
fixes #1700
fixes #1704

- `@mapbox/node-pre-gyp` is effectively unmaintained [1] as has a few bugs
  which our users keep running into
- it seems the prebuilt binary world has moved in favor of prebuild +
  it's various other forms
- one option would be to use prebuildify to bundle all binaries into the
  package, but that's a step too far removed from the current situation
  for now
- instead, we can use prebuild-install to download the binaries, and
  `prebuild` to build + upload the binaries
- this means we can remove node-pre-gyp and fix a bunch of issues!

[1]: mapbox/node-pre-gyp#657
daniellockyer added a commit that referenced this issue Dec 24, 2023
@daniellockyer
Replaced @mapbox/node-pre-gyp in favor of prebuild + `prebuild-in…
bd3cf21 
…stall`

fixes #1641
fixes #1721
fixes #1714
fixes #1713
fixes #1700
fixes #1704

- `@mapbox/node-pre-gyp` is effectively unmaintained [1] as has a few bugs
  which our users keep running into
- it seems the prebuilt binary world has moved in favor of prebuild +
  it's various other forms
- one option would be to use prebuildify to bundle all binaries into the
  package, but that's a step too far removed from the current situation
  for now
- instead, we can use prebuild-install to download the binaries, and
  `prebuild` to build + upload the binaries
- this means we can remove node-pre-gyp and fix a bunch of issues!
- eventually, we could start providing electron prebuilt binaries too

[1]: mapbox/node-pre-gyp#657
@nbransby
Copy link

nbransby commented Jan 21, 2024 •
edited
Loading

That being said, it doesn't look like it would solve my problem: prebuild/prebuild#174

It would appear prebuild is also effectively unmaintained!

Time to switch to prebuildify? prebuild/prebuild#174 (comment)

@nbransby nbransby mentioned this issue Apr 18, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gpetrov @daniellockyer @nbransby