Transient secondary windows

[Schmiddiii]

Licensing

• I confirm that this is either my code or was released under the terms of a GPLv3-or-later compatible license. Also I agree to release it here under the terms of the GPLv3-or-later.

Description

Transient About- and Preferences-Window. The import-window was already transient.

Ping @TheEvilSkeleton for testing.

Linked Issue

Related to #95.

[TheEvilSkeleton]

I can confirm that both Preferences and About windows are now transient. However, the Import window is not.

2022-10-05.16-31-22.mp4

[Schmiddiii]

Maybe now?

To be honest I do not even know what transient-for is even doing, but in the GTK-inspector the property is set to the main window and I do not get a warning that dialogs without transient parent is discouraged.

[TheEvilSkeleton]

transient-for basically sticks the child window with the parent window, so they're not disconnected.

Here's a video that showcases the differences. When I open Preferences and I move the child window around, the parent window follows it as well. However, when I open the Import window, it moves separately.

2022-10-06.11-26-36.mp4

[TheEvilSkeleton]

I just tried it and the Import window is still not transient, from the looks of it. I guess it isn't a big deal since we're going to redesign the window and make sure it works well.

[Schmiddiii]

Then I am just going to merge it for now and work on porting the import window to AdwMessageDialog tomorrow.