Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test changes to MPS #1080

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Test changes to MPS #1080

wants to merge 3 commits into from

Conversation

abelsiqueira
Copy link
Member

🚧 WIP - Don't merge 🚧

This is an initial commit to test whether the MPS file changes.
Currently the check is on runtests, but it might be moved to a separate workflow.

Blocked:

Related issues

Closes #1076

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

@abelsiqueira
Copy link
Member Author

@odow @joaquimg, tagging you in case you have any clues to what could cause this:

  • I run julia --project=. utils/scripts/update-model-mps.jl to generate the .mps of all tests
  • In the tests, I run the same commands as the script to generate the .mps
  • I sort and compare them and there is a difference due to numerical errors:
    ❯ diff <(sort test/tmpdir/Norse.mps) <(sort benchmark/model-mps-folder/Norse.mps )
    40466c40466
    <     rhs       max_energy_over_clustered_year[Midgard_Wind,2030,113:140] 1.1339999999999996e8
    ---
    >     rhs       max_energy_over_clustered_year[Midgard_Wind,2030,113:140] 113400000
    

Any clue to what could cause it?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify in the CI that the MPS files have not changed
1 participant