Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix warning, fix CI and run tests with Julia 1.3 only on Ubuntu #197

Closed
wants to merge 6 commits into from
Closed

Fix warning, fix CI and run tests with Julia 1.3 only on Ubuntu #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94f5353
Fix warning
devmotion Aug 24, 2021
6be0e42
Mark BetaPrime as broken
devmotion Aug 24, 2021
bd445b1
Test Julia 1.3 only with Ubuntu
devmotion Aug 24, 2021
4958962
Bump version
devmotion Aug 24, 2021
ca7c616
Not broken anymore?!
devmotion Aug 24, 2021
c580b82
Fix numerical issues of BetaPrime for α=1
devmotion Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/AD.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,30 @@ jobs:
- '1'
os:
- ubuntu-latest
- macOS-latest
arch:
- x64
AD:
- ForwardDiff
- Tracker
- ReverseDiff
- Zygote
include:
- version: '1'
os: macOS-latest
arch: x64
AD: ForwardDiff
- version: '1'
os: macOS-latest
arch: x64
AD: Tracker
- version: '1'
os: macOS-latest
arch: x64
AD: ReverseDiff
- version: '1'
os: macOS-latest
arch: x64
AD: Zygote
steps:
- uses: actions/checkout@v2
- uses: julia-actions/setup-julia@v1
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/Others.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,12 @@ jobs:
- '1'
os:
- ubuntu-latest
- macOS-latest
arch:
- x64
include:
- version: '1'
os: macOS-latest
arch: x64
steps:
- uses: actions/checkout@v2
- uses: julia-actions/setup-julia@v1
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "DistributionsAD"
uuid = "ced4e74d-a319-5a8a-b0ac-84af2272839c"
version = "0.6.29"
version = "0.6.30"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
2 changes: 1 addition & 1 deletion src/reversediff.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ using ..DistributionsAD: DistributionsAD


import SpecialFunctions, NaNMath
import ..DistributionsAD: turing_chol, symm_turing_chol, _mv_categorical_logpdf, adapt_randn,
import ..DistributionsAD: turing_chol, symm_turing_chol, adapt_randn,
simplex_logpdf
import Base.Broadcast: materialize
import StatsFuns: logsumexp
Expand Down
4 changes: 2 additions & 2 deletions test/ad/distributions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@
DistSpec(Beta, (1.0, 2.0), 0.5),

DistSpec(BetaPrime, (), 0.5),
DistSpec(BetaPrime, (1.0,), 0.5),
DistSpec(BetaPrime, (1.0, 2.0), 0.5),
DistSpec(BetaPrime, (1.5,), 0.5),
DistSpec(BetaPrime, (1.5, 2.0), 0.5),

DistSpec(Biweight, (), 0.5),
DistSpec(Biweight, (1.0,), 0.5),
Expand Down