Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove support for 1.6 LTS #74

Merged
merged 4 commits into from
Dec 9, 2022
Merged

remove support for 1.6 LTS #74

merged 4 commits into from
Dec 9, 2022

Conversation

storopoli
Copy link
Member

This removes supports for Julia 1.6 LTS and updates the CI.yml to use the latest Julia stable release.

@storopoli storopoli requested a review from rikhuijzer December 9, 2022 08:43
@storopoli storopoli self-assigned this Dec 9, 2022
@rikhuijzer
Copy link
Collaborator

This removes supports for Julia 1.6 LTS and updates the CI.yml to use the latest Julia stable release.

Agreed. Ain't nobody got time for that.

To get rid of those "Julia CI (1.6, [...]) Expected --- Waiting for status to be reported", remove the checks from the branch protection rules in the settings (Settings -> Branches -> Branch Protection Rules -> main -> Edit and modify the "Status checks that are required." area there.

@rikhuijzer
Copy link
Collaborator

Maybe also put it in the Project.toml? Does it work on 1.7? Then make that the minimum version in the Project.toml.

@rikhuijzer
Copy link
Collaborator

And also write it somewhere in the top of the documentation what is the least required Julia version. Otherwise, people will be confused when they get an old version of TuringGLM while they should have a new version

@storopoli
Copy link
Member Author

Maybe also put it in the Project.toml? Does it work on 1.7? Then make that the minimum version in the Project.toml.

Yes it does work on Julia 1.7.

And also write it somewhere in the top of the documentation what is the least required Julia version. Otherwise, people will be confused when they get an old version of TuringGLM while they should have a new version

Sure!

Co-authored-by: Rik Huijzer <rikhuijzer@pm.me>
@storopoli
Copy link
Member Author

Ok, approve it and we can enable auto-merge.

@storopoli storopoli enabled auto-merge (squash) December 9, 2022 12:54
@storopoli storopoli merged commit 0aac727 into main Dec 9, 2022
@storopoli storopoli deleted the js-remove-support-lts branch December 9, 2022 13:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants