Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use these across the whole org #12

Open
penelopeysm opened this issue Feb 8, 2025 · 7 comments
Open

Use these across the whole org #12

penelopeysm opened this issue Feb 8, 2025 · 7 comments
Assignees

Comments

@penelopeysm
Copy link
Member

penelopeysm commented Feb 8, 2025

Followup from #11

@shravanngoswamii, I've stuck with two separate workflows because I think it's clearer (especially when, say, you want to trigger the DocsNav part independently; it's a bit confusing to see the action labelled as 'Documentation' which implies that running it will rebuild the docs). Then I fixed a couple of bugs, and I also stuck a setup-julia inside DocsNav since it runs very quickly anyway. And I think we are good to go :)

I think the two workflows in here can be copy pasted into pretty much all repositories:

https://github.com/TuringLang/actions/tree/main/example_workflows

note, when using this Docs.yml we should also get rid of the call to deploydocs in docs/make.jl. That's super easy to forget.

I tested this out on DynamicPPL.jl and TuringBenchmarking.jl and they both work perfectly (and the navbar thing is fixed now).

Feel free to do as many or as few of them as you want!

@penelopeysm
Copy link
Member Author

Also, since we now have the scripts + navbar html here, can we remove it from https://github.com/TuringLang/turinglang.github.io/tree/main/assets/scripts?

@shravanngoswamii shravanngoswamii self-assigned this Feb 9, 2025
@shravanngoswamii
Copy link
Member

Feel free to do as many or as few of them as you want!

@penelopeysm Everything looks good to me, I will start opening PRs now in other repos now!

Also, since we now have the scripts + navbar html here, can we remove it from https://github.com/TuringLang/turinglang.github.io/tree/main/assets/scripts?

Yeah, we will remove it after the updating of all repos to this setup!

@shravanngoswamii
Copy link
Member

Thanks a lot @penelopeysm!😊

shravanngoswamii added a commit to shravanngoswamii/Turing.jl that referenced this issue Feb 9, 2025
shravanngoswamii added a commit to shravanngoswamii/Turing.jl that referenced this issue Feb 9, 2025
shravanngoswamii added a commit to shravanngoswamii/Turing.jl that referenced this issue Feb 9, 2025
penelopeysm added a commit to TuringLang/Turing.jl that referenced this issue Feb 9, 2025
* Using Turing actions for docs

TuringLang/actions#12

* Update DocsNav.yml

Using https://github.com/TuringLang/actions/tree/main/DocsNav
reference: TuringLang/actions#12

* Update make.jl

No need of deploydocs after using [Turing actions](https://github.com/TuringLang/actions/tree/main/DocsDocumenter)

reference: TuringLang/actions#12

* Update Docs.yml

* Update .github/workflows/Docs.yml

Co-authored-by: Penelope Yong <penelopeysm@gmail.com>

* Update .github/workflows/DocsNav.yml

Co-authored-by: Penelope Yong <penelopeysm@gmail.com>

---------

Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
@shravanngoswamii
Copy link
Member

@penelopeysm Some repos have this env, I don't know its use case, should I keep it, or it's necessary?

https://github.com/TuringLang/MCMCChains.jl/blob/fa4ab8d3d5c9651cc309df87886ffb2e78de28fe/.github/workflows/Docs.yml#L27C11-L27C25

@penelopeysm
Copy link
Member Author

I'm not sure if it's needed, but I think better to keep it! It's probably something to do with Plots.jl output.

@penelopeysm
Copy link
Member Author

Thanks for doing so many of them 😅 I know it's quite boring so please feel free to leave some for me

@shravanngoswamii
Copy link
Member

Thanks for doing so many of them 😅 I know it's quite boring so please feel free to leave some for me

Ahh, it's all good🥲!
Almost all of them are done now, and I even took care of the remaining ones too!

Also, since we now have the scripts + navbar html here, can we remove it from https://github.com/TuringLang/turinglang.github.io/tree/main/assets/scripts?

I guess we have to keep it there until someone updates these repos of Julia Gaussian Processes - https://turinglang.org/library/#gaussian-processes, they use different navigation bar

sunxd3 added a commit to TuringLang/JuliaBUGS.jl that referenced this issue Feb 17, 2025
Using [Turing Actions](https://github.com/TuringLang/actions) for
Documentation and global Turing Navigation bar!
Reference: TuringLang/actions#12

---------

Co-authored-by: Xianda Sun <5433119+sunxd3@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants